Bug report in enigma_dyn_conf.cpp

Hello

Not sure it the right place to do it (if you guide me for proper bug reporting), but here you go, in enigma_dyn_conf.cpp 1.9 and older

void initHDDparms(void)
{
#ifndef DISABLE_FILE
eString cmd;
int ti = 0, ac = 0;

eConfig::getInstance()->getKey("/extras/hdparm-s", ti);
eConfig::getInstance()->getKey("/extras/hdparm-m", ac);
if (ac)
{
cmd.sprintf("hdparm -S %d /dev/ide/host0/bus0/target0/lun0/disc", ti);
system(cmd.c_str());
}
if (ti)
{
cmd.sprintf("hdparm -M %d /dev/ide/host0/bus0/target0/lun0/disc", ac);
system(cmd.c_str());
}
#endif
}

I think

Code: Alles auswählen

if(ti)

and

Code: Alles auswählen

if(ac)

could benefit from being swapped.

sr